Carglglz
commented
5 months ago @MathyV I was able to reproduce this
The second problem wasn't so easy to debug: once I soft rebooted, the finalizers were called but it would always crash with a MemoryError. After a lot of scratching my head and a deep-dive into the memory allocation code of both LVGL and MicroPython I found finally that during deinit() the LVGL code is doing calls to realloc which are failing because the garbage collector doesn't want to hand out memory anymore. Whether this is a problem to be solved in LVGL or in MicroPython I'm not sure at this point.
The solution finally was pretty simple: stop using the LV_STDLIB_MICROPYTHON malloc implementation 🤷
The issue is lvgl.deinit() is not freeing mp_lv_roots pointer, here is the diff that solves it:
lv_binding_micropython:diff --git a/gen/gen_mpy.py b/gen/gen_mpy.py index 0f73a60..0ac30f2 100644 --- a/gen/gen_mpy.py +++ b/gen/gen_mpy.py @@ -1333,6 +1333,12 @@ void mp_lv_init_gc() } }
+void mp_lv_deinit_gc() +{
- mp_lv_roots = MP_STATE_VM(mp_lv_roots);
- lv_free_core(mp_lv_roots); +}
-
else // LV_OBJ_T
typedef struct mp_lv_obj_type_t { diff --git a/lv_conf.h b/lv_conf.h index c2d4e6c..e624057 100644 --- a/lv_conf.h +++ b/lv_conf.h @@ -299,7 +299,9 @@ /Garbage Collector settings Used if LVGL is bound to higher level language and the memory is managed by that language*/ extern void mp_lv_init_gc(); +extern void mp_lv_deinit_gc();
define LV_GC_INIT() mp_lv_init_gc()
+#define LV_GC_DEINIT() mp_lv_deinit_gc()
define LV_ENABLE_GLOBAL_CUSTOM 1
if LV_ENABLE_GLOBAL_CUSTOM
- `lvgl`:
```diff
diff --git a/src/lv_init.c b/src/lv_init.c
index cfc46cf15..c20f5331f 100644
--- a/src/lv_init.c
+++ b/src/lv_init.c
@@ -415,6 +415,10 @@ void lv_deinit(void)
lv_initialized = false;
+#ifdef LV_GC_DEINIT
+ LV_GC_DEINIT();
+#endif
+
LV_LOG_INFO("lv_deinit done");
#if LV_USE_LOG[EDIT] after some testing this doesn't solve it either.
mp_lv_roots is used for lv_global_t struct and with lvgl.deinit only indevand display are being free.
static inline void _lv_cleanup_devices(lv_global_t * global)
{
LV_ASSERT_NULL(global);
if(global) {
/* cleanup indev and display */
_lv_ll_clear_custom(&(global->indev_ll), (void (*)(void *)) lv_indev_delete);
_lv_ll_clear_custom(&(global->disp_ll), (void (*)(void *)) lv_display_delete);
}
}It seems like a lv_global_deinit function is what is needed? 🤔
MathyV
I wasn't sure whether to report this as an issue or not, so feel free to immediately close it, I just wanted to document this for others to find if they were experiencing the same issues as me.
TLDR: using the default
lv_conf.halso present in this repository, I failed to have soft-reboots working properly, but I found a solution.The first hurdle, getting to a clean state, was fairly easily taken by implementing finalizers and using the
deinit()function. After that, I could completely tear down and rebuild my setup by manually calling the functions in REPL multiple times in a row and it would keep working.The second problem wasn't so easy to debug: once I soft rebooted, the finalizers were called but it would always crash with a MemoryError. After a lot of scratching my head and a deep-dive into the memory allocation code of both LVGL and MicroPython I found finally that during
deinit()the LVGL code is doing calls toreallocwhich are failing because the garbage collector doesn't want to hand out memory anymore. Whether this is a problem to be solved in LVGL or in MicroPython I'm not sure at this point.The solution finally was pretty simple: stop using the
LV_STDLIB_MICROPYTHONmalloc implementation :shrug:Here you can see how I solved it in my implementation: https://github.com/MathyV/lvgl_esp32_mpy/commit/e84196d20415162422b7ead386934419384a66d6
I don't know if this is the best (temporary?) solution but so far I haven't experienced any issues with it yet.
PS: after fixing this I also had issues with
deinit()ofmachine.SPIin the ESP32 MicroPython implementation but that is definitely out of scope here, still, here's how I fixed it as an FYI: https://github.com/MathyV/lvgl_esp32_mpy/commit/7330fcc6bdc23e84a8e1bb8db0970650338f5940