search

lvgl / lv_demos

Examples, tutorials and applications for the LVGL embedded GUI library
https://lvgl.io
488 stars 366 forks source link

Would a PR to update to v8.3.1 of lvgl be considered? #152

Closed chmorgan closed 2 years ago

chmorgan commented 2 years ago

Updated lvgl from v8.1 to 8.3.1 and seeing errors due to changes in lv_obj_draw_part_dsc_t, I think a property was renamed.

I think I can fix it, would a PR to correct be something you'd consider accepting upstream?

embeddedt commented 2 years ago

The demos are in the main repository as of 8.2 so you shouldn't need to use this one with 8.3.

chmorgan commented 2 years ago

@embeddedt oh very good, should I open a PR to clarify this in the README.md? It says the repo is obsolete but doesn't say when/where. Would it make sense to flag the repo as archived to be super clear that its obsolete?

kisvegabor commented 2 years ago

image It seems clear to me, but if wasn't for you, probably it isn't clear for others either.

So please send a PR to update the top text. :slightly_smiling_face:

As a reasonable time has passed since we merged the demos to lvgl we can archive this repo when your PR is merged.

chmorgan commented 2 years ago

Opening a PR in just a min.

chmorgan commented 2 years ago

https://github.com/chmorgan/lv_demos/pull/1

embeddedt commented 2 years ago

@chmorgan I think you opened your PR on your own fork by accident.

chmorgan commented 2 years ago

bah, https://github.com/lvgl/lv_demos/pull/153

chmorgan commented 2 years ago

Jesus, wrong repo again...

chmorgan commented 2 years ago

ok no, it looks ok. I thought somehow I opened against lvgl/lvgl. hah

embeddedt commented 2 years ago

Thanks! I will archive this repo now.