removed a few bugs when testing the examples on the javascript port

lvgl / lv_demos

Examples, tutorials and applications for the LVGL embedded GUI library

https://lvgl.io

489 stars 366 forks source link

removed a few bugs when testing the examples on the javascript port #98

Closed uraich closed 3 years ago

uraich commented 3 years ago

I went through the lvgl doc and tried all the Python examples. By doing so I found a few bugs in my code and corrected. I still have problems with the examples using images, where the image files are not found. The following examples work with the unix port but give trouble with the javascript simulator:

container
label, example 2
line objmask example 1

embeddedt commented 3 years ago

I will merge it and trigger a rebuild!

I think the container example is having problems because of the time.sleep statements, which don't work properly on the JS simulator due to the original upstream port not having complete suspension support.
The label example fails because of the while loop at the end.
The objmask example fails because of the while loops which check how many ticks have elapsed; I'm not sure that this will work properly on the simulator.

uraich commented 3 years ago

Wow, his was fast! I took out the while loop from the label 2 example. What do we have to do to get the images straight? Problems are in

img
imgbtn
gauge Then I think you don't need the else clause in the header. _import displaydriver and import utime as time should work in both cases

embeddedt commented 3 years ago

I haven't decided for sure yet, but I am thinking I will tweak the JS simulator so that it can behave like the rest of the ports with regards to the images. Otherwise, we will be forced to have a separate set of image URLs and/or examples.