search

lvgl / lv_drivers

TFT and touch pad drivers for LVGL embedded GUI library
https://docs.lvgl.io/master/porting/index.html
MIT License
290 stars 309 forks source link

Add a way to set SDL window title from lv_drv_conf.h #277

Closed hanhsuan closed 1 year ago

hanhsuan commented 1 year ago

I'm trying to use LVGL and SDL to write one cross platform GUI application, but the window title for SDL is hardcode in the sdl.c. Therefore, it would be nice to have a way to set SDL window title from lv_drv_conf.h just as other setting.

kisvegabor commented 1 year ago

It's ok, but please add an 

#ifndef SDL_WINDOW_TITLE
#define SDL_WINDOW_TITLE "TFT Simulator"
#endif

in sdl.c.

Note that, we have already moved the SDL driver to LVGL master branch. When LVGL v9 will be released this repository will be detracted. So it might be worth adding the same feature in LVGL master too.

hanhsuan commented 1 year ago

I will go to add this feature to the LVGL master. Thanks a lot for your notice.

hanhsuan commented 1 year ago

Should I follow what lvgl v9 to modify this PR, or close ?

kisvegabor commented 1 year ago

Sorry for the delay.

This repo mostly uses define based configurations we can keep it as it is.

Merging