Change `_p` to `_pl` - Githubissues

PierreRambaud commented 2 years ago

I don't know if it's interesting for you, but each time I compile I need to change this define because of the framework arduinoexpressif32

In file included from .pio/libdeps/m5stack-core2/M5Core2/src/M5Core2.h:73,
                 from lib/Pokegotchi/Utils.h:6,
                 from lib/Pokegotchi/Menu.h:6,
                 from lib/Pokegotchi/ActionsMenu.h:6,
                 from lib/Pokegotchi/Game.h:7,
                 from lib/Pokegotchi/Game.cpp:3:
/home/got/.platformio/packages/framework-arduinoespressif32/libraries/FS/src/FS.h:50:47: error: macro "_p" requires 2 arguments, but only 1 given
     File(FileImplPtr p = FileImplPtr()) : _p(p) {

puzrin commented 2 years ago

Sorry, this is stable package, and breaking changes can not be accepted (at least, without preliminary discussions). I'm sure, such collisions can be solved in better way (proper order of include/undef, for example).

PierreRambaud commented 2 years ago

Sorry, this is stable package, and breaking changes can not be accepted (at least, without preliminary discussions). I'm sure, such collisions can be solved in better way (proper order of include/undef, for example).

Thank for your answer, I'll try to investigate more ^^

lvgl / lv_i18n

Change `_p` to `_pl` #47