Add Docker support - Githubissues

lvgl / lv_img_conv

Image converter for LVGL, written in JS

https://lvgl.github.io/lv_img_conv/

Other

94 stars 42 forks source link

Closed robert-alfaro closed 2 years ago

robert-alfaro commented 2 years ago

Adding dockerfile and entrypoint to allow direct and interactive shell usage of lv_img_conv.js

Only issue you may find with the PR is the reference to my personal docker hub repository; please advise.

embeddedt commented 2 years ago

For the Docker reference I think we have two options:

Set up a Docker Hub organization for LVGL and publish the image there. I will also need to look into how to publish new versions automatically when a commit is pushed/a release is made.
Rewrite the instructions to always build locally and remove any references to the prebuilt image.

@kisvegabor Which do you think is best? I think this image can build fast enough that we don't necessarily need to publish a prebuilt version.

kisvegabor commented 2 years ago

Rewrite the instructions to always build locally and remove any references to the prebuilt image.

I vote for this to get our feet wet with Docker in LVGL. Building locally is only a one time issue but makes maintenance mush easier.

robert-alfaro commented 2 years ago

Ok cool, I'll update for building / running locally :)

kisvegabor commented 2 years ago

Great, thanks :)

robert-alfaro commented 2 years ago

@kisvegabor I got delayed...finally updated the README :)

embeddedt commented 2 years ago

Looks good! Thank you. Hopefully this helps make installation easier for some developers.