search

lvgl / lv_port_linux

LVGL configured to work with a standard Linux framebuffer
MIT License
260 stars 160 forks source link

build: Add Helper rule to update gitmodules #15

Closed rzr closed 2 years ago

rzr commented 3 years ago

Signed-off-by: Philippe Coval philippe.coval@huawei.com

kisvegabor commented 3 years ago

On every make will it automatically update submodules too? If so will make fail is there is no internet connection?

rzr commented 3 years ago

not if prep.tmp file is there

kisvegabor commented 3 years ago

I see, I've tried it out and it was working well. But I'm thinking about if there could be any unwanted unexpected consequences if the submodules are updated automatically. E.g. someone uses lvgl v8.0.2 but v8.1 will be out it's not certain that he want to update to the new minor version automatically.

I'd rather leave for the user to update the submodules as he wish.

rzr commented 3 years ago

ok let me update this change to pull only if missing

kisvegabor commented 3 years ago

Sounds good!

kisvegabor commented 3 years ago

I don't know why but the content of lvgl.mk, lv_drivers.mk or lv_demos.mk randomly gets overwritten by this content:

lv_demos/lv_demo.mk
lv_drivers/lv_drivers.mk
lvgl/lvgl.mk

E.g. when lv_demos.mk was overwritten:

$ make
info: Preparing sources
git submodule init
git submodule update
info: Sources prepared ready to build again
Makefile:50: recipe for target 'lv_demos/lv_demo.mk' failed
make: *** [lv_demos/lv_demo.mk] Error 1
embeddedt commented 3 years ago

It's been a while since I worked with a Makefile, but I think this line is the culprit.

stale[bot] commented 3 years ago

This issue or pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.