search

lvgl / lv_port_pc_vscode

MIT License
217 stars 136 forks source link

build: Support bitbake #8

Closed rzr closed 2 years ago

rzr commented 2 years ago

This will fix observed issues:

Subprocess output:arm-poky-linux-musleabi-strip:
/.../demo: file format not recognized

ERROR: lvgl-0.0.0-r012 do_package_qa:
QA Issue: File /usr/lib/lvgl/bin/demo in package lvgl
doesn't have GNU_HASH (didn't pass LDFLAGS?) [ldflags]

Relate-to: https://github.com/lvgl/lvgl/issues/2534 Signed-off-by: Philippe Coval philippe.coval@huawei.com

microwavesafe commented 2 years ago

I'm not familiar with bitbake, but your changes to the Makefile are simply changing a variable name and adding it the compile command line in the same place as before. This doesn't seem to change anything? This also leaves in the now empty $(LDFLAGS).

Looking at the QA issue it seems to revolve around NOT passing ldflags, I'm not sure what bitbake requires to satisfy this QA issue?

microwavesafe commented 2 years ago

OK I think I get it. I'm not using LDFLAGS as per convention, The convention is to use LDLIBS for libraries. Can you try again only changing LDFLAGS to LDLIBS in both locations?

rzr commented 2 years ago

updated, yea LDFLAGS can be still defined from the outside (bitbake env) so I am keeping it in the link line

microwavesafe commented 2 years ago

Makes sense