Bug fixes in image converter

robwin311 commented 5 years ago

Hi,

I fixed some bugs in image converter. Unfortunately I haven't got enough time to resolve all problems and warnings, however I've marked all warnings that I detected in code.

Fixes:

The converter didn't work when running offline, because there were no $cf variable declared. I've added that.
There were some wrong calls to class constants. Inside class they should be preceded by self::, outside class by class_variable::
Some code remains from previous converter, some code was unnecessary.
Because of no $this-> inside dithering section, it do not work. Now it should!

All warnings was suppressed in order to detect all of them. They are marked with // TODO

kisvegabor commented 5 years ago

Hi Robert,

Thank you very much for the fixes! I will check the script offline to see the warning messages.

kisvegabor commented 5 years ago

I fixed the mentioned warnings. Can you review it? https://github.com/littlevgl/lv_utils/commit/97da65a9e1b7eb08379a4739c5b0495c6f2b779f

lvgl / lv_utils

Bug fixes in image converter #10

Fixes: