search

lvgl / lvgl_esp32_drivers

Drivers for ESP32 to be used with LVGL
MIT License
339 stars 285 forks source link

Merge master into develop #191

Closed tore-espressif closed 2 years ago

tore-espressif commented 2 years ago

Closes https://github.com/lvgl/lvgl_esp32_drivers/issues/146

tore-espressif commented 2 years ago

@C47D This PR resolves conflicts between master and develop. It can be successfully build (check GH actions)

I'll have to test in on HW before merging, though

tore-espressif commented 2 years ago

Update: tested and working with ESP32S2 + ST7789 + LVGL v8.

I understand that the other drivers were not updated to LVGL v8 yet.

C47D commented 2 years ago

Hi @tore-espressif, as far as I remember that particular driver is the only one that works with both LVGL v7 and v8.

Thanks for taking the time to solve this issue, I know is not very fun to do :)

tore-espressif commented 2 years ago

Well, I caused the whole problem, it's shame that it took me so long.

If this gets merged into develop, do you want to merge develop to master ASAP? As far as I understand it, there will be inconsistencies between drivers.

(Related discussion https://github.com/lvgl/lvgl_esp32_drivers/pull/188)

C47D commented 2 years ago

Hi, don't worry. We could merge develop into master and firstly fix compilation errors. Then update drivers gradually. What do you think?

tore-espressif commented 2 years ago

Fair enough 👍

C47D commented 2 years ago

Feel free to merge this.