Fix tests on CI

[eploko]

Before we possibly try to move the tests to GH Actions as was suggested in https://github.com/lvh/caesium/issues/68#issuecomment-689265350 I guess we should make some effort to make the current CI builds green firstly. This PR is an attempt to do just that.

Goals:

• [x] Get rid of the cljfmt errors.
• [x] Fix as much of the eastwood linting warnings as possible.
• [x] Make the tests pass.
• [x] Make the build on Travis CI green.

[lvh]

FWIW, I would completely understand if you want to fix Eastwood first, but I've had mostly a good time with clj-kondo. https://github.com/latacora/wernicke has example workflows (in GitHub Actions, though: not Travis). I'm fine with Eastwood too! But mostly don't feel like you have to get Eastwood working because that's what was there :)

[lvh]

Also happy to follow your guidance re: if you want this to be a single contained PR that makes CI work, or if you'd rather do a series of smaller PRs that get CI a bit closer to working.

[eploko]

FWIW, I would completely understand if you want to fix Eastwood first, but I've had mostly a good time with clj-kondo. https://github.com/latacora/wernicke has example workflows (in GitHub Actions, though: not Travis). I'm fine with Eastwood too! But mostly don't feel like you have to get Eastwood working because that's what was there :)

The preference isn't a strong ground to change the tool, albeit I tend to use clj-kondo in my other projects as well. :) The warnings were quite easy to fix, so just sticking with it is fine I guess for now. I doubt clj-kondo will be any different in terms of integrating in GH Actions later. Please tell me if you'd like eastwood replaced and we can look into it at a later stage.

[eploko]

Also happy to follow your guidance re: if you want this to be a single contained PR that makes CI work, or if you'd rather do a series of smaller PRs that get CI a bit closer to working.

Let's stick with a single PR if it's okay with you. I don't expect too many changes to make it all work.

[eploko]

Alright, the tests pass locally for me on libsodium 1.0.18, but we need to come to a solution on #70 before fixing the CI build.

[eploko]

All green. I guess this is now ready for review. Please let me know if I missed anything.

[eploko]

Btw, I took liberty to use the official libsodium sources for the CI runs. The distribution signature is verified during the build and the corresponding libsodium public key is added as libsodium.pub at the root of the repo. The key is retrieved from https://doc.libsodium.org/installation#integrity-checking

Please let me know if it'd be more appropriate to add a deb for the new libsodium version to https://github.com/lvh/libsodium-debs instead.

[eploko]

Please let me know what are your plans on merging this in. I guess we move on with adopting Github Actions next?

[lvh]

Sorry! I thought I clicked merge already, clearly I was mistaken :sweat_smile:

[lvh]

And yes, GitHub Actions would be awesome.