search

lvh / caesium

Modern cryptography (libsodium/NaCl) for Clojure
Eclipse Public License 1.0
180 stars 28 forks source link

Side-effect, loading Sodium too early #86

Open piotr-yuxuan opened 2 years ago

piotr-yuxuan commented 2 years ago

Hello! Thanks very much for this great work. For some project I've been trying to setup CI jobs that runs on GitHub Actions, and I believe that caesium trying to load sodium when loading ns makes the job fails. See an example for caesium itself analysed by cljdoc (link).

What would you think about putting these forms in a function that gets called on runtime startup, and not at compile time? https://github.com/lvh/caesium/blob/master/src/caesium/binding.clj#L720-L725

Cheers, Piotr

lvh commented 2 years ago

Sure, that seems fine. Perhaps a delay?

lvh commented 2 years ago

I guess I should rephrase: can you be more specific w.r.t "runtime startup"? :)