lvicainne / puppet-opendkim

Puppet module for opendkim
https://forge.puppetlabs.com/lvicainne/opendkim
Other
5 stars 32 forks source link

Required puppet version ? #10

Closed Yyuzu closed 7 years ago

Yyuzu commented 7 years ago

Hi,

Which puppet version is required for the module to work ?

I tried it before #5 and it complained about that line:

Error: Could not retrieve catalog from remote server: Error 400 on SERVER: Syntax error at '.'; expected '}' at /etc/puppet/modules/opendkim/manifests/config.pp:114

Which was containing:

$opendkim::keys.each

Now that #5 has been merged, it fails with:

Error: Could not retrieve catalog from remote server: Error 400 on SERVER: Syntax error at 'String'; expected ')' at /etc/puppet/modules/opendkim/manifests/init.pp:7

Is it compatible with debian jessie (oldstable) version 3.7.2-4 ? As stretch is fairly recent, it might not be compatible with most debian user's puppet installs.

Maybe you could tag different revisions of this module with some milestones / version compatibility ?

Anyways, thanks for your work. Cheers

Loïc

lvicainne commented 7 years ago

Hello @Kyoshiro-san Thanks for your attention ! You are fully true : the manifest was not up-to-date compare to the last pull-request (I mean, we are no more compatible with Puppet older than 4.8). Thus, i built today a new branch :

To follow this new evolution, I created also a new nomenclature for the versions of this module :

I expect you will find your happiness :-) Feel free to comment ;-) I took some time between your issue and its solve Rgds

Yyuzu commented 7 years ago

Thank you very much for clarifying and for the branch ^_^ Right now I'm using puppet 3.7 from debian jessie but I'll most certainly upgrade to 4.x from backports or even to stretch directly.

Cheers ! Loïc

lvicainne commented 7 years ago

You're welcome ;-)