search

lvicainne / puppet-opendkim

Puppet module for opendkim
https://forge.puppetlabs.com/lvicainne/opendkim
Other
5 stars 33 forks source link

Consider fixing breaking changes from v0.2.9 to v0.3.0 #40

Closed tallenaz closed 4 months ago

tallenaz commented 5 months ago

Hello,

We are testing an upgrade from v0.2.9 to v0.3.0 and are seeing some file ownership and permissions changes that cause opendkim to fail on one of two servers we use this module with.

I forked the module and added changes that make the upgrade a noop on both of our machines. The changes are here: https://github.com/lvicainne/puppet-opendkim/compare/main...tallenaz:puppet-opendkim:master

It looks like the ownership and permissions changes happened between commits 504d2689f and 4430b9e82.

I'm wondering if others have seen this same behavior. I hesitate to issue a PR with the above changes, since it might cause issues for others. One thought is that I could work up a PR that makes the ownership and permissions more configurable on a per file basis, but if you have any thoughts on this, they would be much appreciated!

tallenaz commented 4 months ago

Thank you! Closing as fixed by https://github.com/lvicainne/puppet-opendkim/pull/41