search

lvicainne / puppet-opendkim

Puppet module for opendkim
https://forge.puppetlabs.com/lvicainne/opendkim
Other
5 stars 33 forks source link

add force to directory absent resources #9

Closed qs5779 closed 6 years ago

qs5779 commented 6 years ago

add force to directory absent resources, added style specified class name at top

my version of puppet will not remove a directory unless force is true ( or yes ) caused a refresh for every puppet run

qs5779 commented 6 years ago

And just as an FYI I think you are defaulting to the incorrect directories for RedHat, and Ubuntu. I run CentOS a RedHat family, and Ubuntu a Debian family. Here are their base confg files respectively.

root@nim:/etc/opendkim

rpm -ql opendkim | grep etc

/etc/opendkim /etc/opendkim.conf /etc/opendkim/KeyTable /etc/opendkim/SigningTable /etc/opendkim/TrustedHosts /etc/opendkim/keys /etc/sysconfig/opendkim /etc/tmpfiles.d/opendkim.conf root@nim:/etc/opendkim

cat /etc/redhat-release

CentOS Linux release 7.3.1611 (Core)

✔ ~/my/dev/pup/wtfo [production|✔] 13:55 $ dpkg-query -L opendkim | grep etc /etc /etc/opendkim.conf /etc/dkimkeys /etc/dkimkeys/README.PrivateKeys /etc/init.d /etc/init.d/opendkim /etc/default /etc/default/opendkim ✔ ~/my/dev/pup/wtfo [production|✔] 14:51 $ uname -a Linux toshiba-ubuntu

lvicainne commented 6 years ago

Hi @qs5779 ! Thanks for this other PR ! :-) I take note about the usual default directory, I will do a commit soon !