lvivier / step-gh-pages

deploy github pages with wercker
37 stars 35 forks source link

GIT_REPOSITORY Env Variable is not storing the correct value #3

Closed tusharmath closed 11 years ago

tusharmath commented 11 years ago

My repository name is: tusharmath.github.io but the Env Variable WERCKER_GIT_REPOSITORY stores tusharmath as its value. Im not sure why this is happening. Probably its a bug in Wercker's way of parsing repository name?

Any ways it seems like WERCKER_APPLICATION_NAME stores the correct value of the repository. So should we update run.sh to use WERCKER_APPLICATION_NAME instead of WERCKER_GIT_REPOSITORY?

Because other wise the step just fails completely for my repository.

lvivier commented 11 years ago

I'm not sure whether WERCKER_APPLICATION_NAME is guaranteed to be equal to the repo name. You can set the repo option to "tusharmath/tusharmath.github.io" in the step config of wercker.yml and then it should build correctly. It would be helpful if you could get in touch with the wercker guys about your repo name, though. I'll see what they have to say.

pjvds commented 11 years ago

This is a bug on wercker that should be fixed now. I have forked your repository to reproduce the problem and deployed a fix. Here you see the correct result: https://app.wercker.com/#buildstep/521f345c8dad4f0004000a55

This closes: wercker/support#7

tusharmath commented 11 years ago

@pjvds thanks for fixing this bug! @lvivier We don't need to work on this issue any more.