lvlrSajjad / react-native-blur-overlay

React Native Blur Overlay Library For Ios And Android

MIT License

95 stars 34 forks source link

Performance / Robustness / Responsiveness / Code style / Upgrading improvements #3

Closed chubakueno closed 5 years ago

chubakueno commented 5 years ago

Improvements:

Android native module:

Use event emitter instead of binding function to component (Robustness)
Move blur to background task (Responsiveness)
Don't include decor views while taking screenshot (Performance + robustness)
Implement downsampling (Performance)
Dead code elimination, code deduplication (Code style)

JS bridge:

Include prop types for newer versions of React (Upgrading)

lvlrSajjad commented 5 years ago

Thank's @chubakueno you really done a good job I will release it after merging