search

lvm / build-supercollider

A dead simple script that builds and installs Supercollider
The Unlicense
67 stars 14 forks source link

Removed reference to outdated SC3 plugin branch #23

Closed murraycs closed 3 years ago

murraycs commented 3 years ago

The 3.10 branch of the SC3 plugins repository contained an error in one of the plugins, that had been corrected in the master branch. When running the build-sc3-plugins script, it repeatedly failed due to the error. I removed the code that cloned the 3.10 branch.

lvm commented 3 years ago

Hi! There's no need to remove --branch $SUPERCOLLIDER_VER from the git command. The idea of having a SUPERCOLLIDER_VER environmental variable is to be used later when cloning the correct branch, which as you already pointed is 3.11.

I could merge this PR if you just edit the version on SUPERCOLLIDER_VER but not without the --branch flag.

murraycs commented 3 years ago

Got it! Should be good now.

lvm commented 3 years ago

Thanks