lvm / build-supercollider

A dead simple script that builds and installs Supercollider
The Unlicense
67 stars 14 forks source link

HotFix: Adjust For Supercollider SC3 Plugins Branch/Tag Naming #24

Closed irishgordo closed 3 years ago

irishgordo commented 3 years ago

Resolves: fix/adj_supercollider_ver_edit

lvm commented 3 years ago

(Sorry i'm a bit out of the loop around these parts lately)

if i understood correctly, this fix switches from git-branch to git-tag therefore cloning the correct version, right? If that's the case, makes total sense. Will trust you and go ahead with the merge :-)

Thanks!

irishgordo commented 3 years ago

@lvm thanks for merging :)!

Yeah, pretty much prior to merge the shell script would fail since the branch 3.11 didn't exist for the repo it was fetching, decided to leverage tag - since they had a 3.11.0 based tag that was prefixed with "Version-"

So yeah, totally would allow us to ensure we get tag-based branches and snag the right version when we need it :).

We can hope that will be a good pattern to follow / more-future-proof, but I guess we'll see :) I'll keep an eye out - also if there are any issues with the shell-script that pops up in the next bit, feel free to assign them to me and I can take a look at them :)