AspectFit and Aspect Fill mode don't work properly when using Zoomy intazoom mode

lvnkmn / Zoomy

Adds seamless scrollView and instagram like zooming to UIImageViews in any view hierarchy.

MIT License

206 stars 25 forks source link

AspectFit and Aspect Fill mode don't work properly when using Zoomy intazoom mode #62

Closed bizibizi closed 5 years ago

bizibizi commented 5 years ago

It;s crashing all UI basically. Can you check it please?

bizibizi commented 5 years ago

i am using those methids as well

extension YourViewController: Zoomy.Delegate {

func didBeginPresentingOverlay(for imageView: UIImageView) {
    scrollView.isScrollEnabled = false
}

func didEndPresentingOverlay(for imageView: UIImageView) {
    scrollView.isScrollEnabled = true
}

}

bizibizi commented 5 years ago

well, i solved that with https://github.com/ergunemr/EEZoomableImageView

lvnkmn commented 5 years ago

Glad you have been able to fix this in your code. This is a known issue indeed. Currently Zoomy doesn't have full support for all content modes and works best when the aspect ratio of the image and the aspect ratio of the image view it's displayed in stay the same.

lvnkmn commented 5 years ago

@bizibizi I've found some time and will pick this issue up. Since I see you have been dealing with this in the insta zoom mode, I will first solve it in this mode (and later for the scroll based mode in #67)