search

lvogt / ioBroker.wireless-mbus

ioBroker wireless M-Bus adapter
GNU General Public License v2.0
6 stars 4 forks source link

Ignoring contains_crc for Frame B #130

Closed Arthedian closed 1 year ago

Arthedian commented 1 year ago

I discovered that in the "decodeLinkLayer" function of "wmbus_decoder.js," when parsing Frame B, the variable "contains_crc" is not utilized. As a result, if a message doesn't have a CRC, it throws an error even if the message is fine. If I understand correctly, setting "contains_crc" to False should not matter which Frame it is.

lvogt commented 1 year ago

That ia true. However, the question is, do you have a setup where you receive frame type B with already stripped CRC data? If yes, please supply a debug log, or at the very least, which receiver do you use?

Am 29. Mai 2023 16:17:04 MESZ schrieb Arthedian @.***>:

I discovered that in the "decodeLinkLayer" function of "wmbus_decoder.js," when parsing Frame B, the variable "contains_crc" is not utilized. As a result, if a message doesn't have a CRC, it throws an error even if the message is fine. If I understand correctly, setting "contains_crc" to False should not matter which Frame it is.

-- Reply to this email directly or view it on GitHub: https://github.com/lvogt/ioBroker.wireless-mbus/issues/130 You are receiving this because you are subscribed to this thread.

Message ID: @.***>

Arthedian commented 1 year ago

Sorry, I didn't see the notification. I am not using any USB receiver. I receive WMB batch files over FTP, which don't have CRC. Currently, I always set Frame A, so it isn't much of a problem. However, when experimenting with your library, I noticed this and thought I should report it.

lvogt commented 1 year ago

Fixed by fda35c6578d5e74690b1eebf9da005b6f230a80a