lvogt / ioBroker.wireless-mbus

ioBroker wireless M-Bus adapter
GNU General Public License v2.0
6 stars 4 forks source link

Added valueFactor to datarecords for better conversion from m3 #146

Closed TheDiscoScript closed 3 weeks ago

TheDiscoScript commented 1 year ago

I think this change has value in case you want to convert units. For example if we have IoT device with watermeter, thanks to valueFactor we will know if VIF_VOLUME is in liters or in m3.

DIF/VIF  04 13  -  0x13: ‘Volume l’,     - valueFactor: 0.001
DIF/VIF  04 16  -  0x16: ‘Volume m³’,  - valueFactor: 1
lvogt commented 1 year ago

I am sorry, but I think this will confuse people (even though very few will actually look at the parser output without using the actual adapter anyway):

The valueFactor is already applied on the final output value. So the only additional information you get out of this, is what range was actually used in the telegram.

But maybe I did not understand your motivation?

lvogt commented 8 months ago

Any comment? Otherwise this will be closed without merging it.