search

lvps / 389ds-server

Ansible role to configure 389DS
Apache License 2.0
23 stars 14 forks source link

The 'params' option for 'ldap_attrs' is not working anymore #2

Closed adellam closed 4 years ago

adellam commented 4 years ago

ldap_attr -> params is not supported anymore since at least ansible version 2.8.11.

lvps commented 4 years ago

Thanks for the pull request!

I just noticed that you added start_tls and validate_certs only in some places when replacing params: probably it still works fine, but I remember there were a lot of edge cases around those parameters, so I'd rather have a 1:1 replacement, unless there was a specific reason for you to remove them?

In any case, later today (in ~4 hours) I will make that small change and merge your changes.

adellam commented 4 years ago

Thanks for the pull request!

I just noticed that you added start_tls and validate_certs only in some places when replacing params: probably it still works fine, but I remember there were a lot of edge cases around those parameters, so I'd rather have a 1:1 replacement, unless there was a specific reason for you to remove them?

Nope sorry, I was in a hurry and I didn't check that I reported all the parameters everywhere.