Closed GoogleCodeExporter closed 9 years ago
Thanks for the report. Do you happen to have a simple test case of the issue?
Original comment by emartin24
on 11 Jun 2009 at 8:58
Sorry, rude of me not to include steps to recreate.
It is a little weird, aka still dealing with design mistakes from the 90's.
There are two frames one is a library with JavaScript the other with content.
The
content frame calls a function in the library frame to create a pop-up. The
library
frame uses the content's frame "window" object to get its jQuery and
simplemodal then
calls creates the pop-up. The crux is that the library frame creates the array
for
"position" option. It is then passed into a function under the content frame's
scope.
Therefor the constructor function for the "position" option and the Array
constructor
in simplemodal are different.
Like I said weird and honestly stupid, but its slow and difficult work to change
legacy stuff.
Attached is a zip with the needed frameset and html files to show the issue. A
copy
of simplemodal 1.3b1 and "my" simplemodal with changes that fix the issue.
Hope that helps!
Original comment by cavi...@gmail.com
on 11 Jun 2009 at 10:27
Attachments:
Sorry it took me so long to get around to this. I changed the line in question
to:
if (this.opts.position && Object.prototype.toString.call(this.opts.position) ===
"[object Array]") {
That seems to fix the problem (borrowed the code from jQuery's isArray
function).
Look for the fix to show up in the next release (1.3.1).
Thanks for the report and example code!
Original comment by emartin24
on 20 Aug 2009 at 6:23
Original issue reported on code.google.com by
cavi...@gmail.com
on 11 Jun 2009 at 7:43