search

lw-bobbimartin / simplemodal

Automatically exported from code.google.com/p/simplemodal
0 stars 0 forks source link

minHeight not working #34

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
SimpleModal or SimpleModal Contact Form (SMCF)?
Simple Modal

Version of SimpleModal of SMCF (indicate Demo or WordPress plugin)?

Version of jQuery?
1.4.1

Browser/OS you are experiencing the problem with?
Firefox 3.6, WinXP SP2

If applicable, please provide a code snippet or link to a website
demonstrating the problem.
CSS applied:
#simplemodal-overlay {
    background-color:#000;
}

#simplemodal-container {
    background-color:#333;
    border:8px solid #444;
    padding:12px;
}

JS applied:
    $.modal.defaults.overlayClose = true;
    $.modal.defaults.onOpen = function (dialog) {
        dialog.overlay.fadeIn('',
            function () {
                dialog.container.fadeIn();
                dialog.data.fadeIn();
            }
        );
    };
    $.modal.defaults.onClose = function (dialog) {
        dialog.container.fadeOut('',
            function () {
                dialog.overlay.fadeOut('',
                    function () { $.modal.close(); });
            }
        );
    }

    $('.help').click(function() {
        $('#modal_' + this.id.substr(5)).modal();
        return false;
    });

When run, the modal window does not fit the content, instead just
maintaining the minHeight.

If applicable, please list the other code/libraries/plugins you are trying
to integrate with.

Original issue reported on code.google.com by ro...@rhovisions.com on 12 Feb 2010 at 10:27

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
I'd need to see more of the code in order to know what is going on. I'll be 
releasing a 
version soon that might fix some of these problems, though I suspect you could 
get it 
working through the SimpleModal options or CSS.

Original comment by emartin24 on 5 Mar 2010 at 10:33

GoogleCodeExporter commented 9 years ago 
There is a problem that is caused by using the defaults of:

$('.message', dialog.data[0]).append(html);

and

<p class="message"> 

When trying to append any value for html that contains divs, it's being 
appended to a
<p> so it doesn't display correctly, and this seems to cause heights to break.

Changing to this might be all that is needed.

<div class="message"> 

Cheers,

Mark...

Original comment by wabznas...@gmail.com on 12 Mar 2010 at 7:25

GoogleCodeExporter commented 9 years ago 
Not sure if this was for a specific demo/example? I updated the confirm code 
with a 
div, so it should be fixed now.

Original comment by emartin24 on 20 Apr 2010 at 5:15