lw-bobbimartin / simplemodal

Automatically exported from code.google.com/p/simplemodal
0 stars 0 forks source link

Inconsistent implementation of login_form hook in SimpleModal Login #49

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
This is a repost of this issue:
http://wordpress.org/support/topic/plugin-simplemodal-login-inconsistent-impleme
ntation-of-login_form-hook?replies=1#post-1795668

The wp-login.php file runs the do_action('login_form') hook as the login form 
is being printed. SimpleModal on the other hand builds the login form as a 
variable, runs the login_form action during this process, and then prints the 
entire form later.

Many plugins that hook to do_action('login_form') print output, meaning if used 
with SimpleModal, output will be printed outside of the login form.

A workaround is to unhook functions on login_form and then use the 
simplemodal_login_form filter but it would be much better to have the 
login_form hook act consistently with that in wp-login.php.

Original issue reported on code.google.com by Brent.E....@gmail.com on 18 Nov 2010 at 7:58

GoogleCodeExporter commented 9 years ago
I checked in a few minor updates, but still need to get to this...

Original comment by emartin24 on 3 Dec 2010 at 12:31