search

lw-bobbimartin / simplemodal

Automatically exported from code.google.com/p/simplemodal
0 stars 0 forks source link

Simplemodal just stopped working (couple of days) #92

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
SimpleModal

Version of SimpleModal: v1.4.3

Version of jQuery? jQuery v1.9.0

Browser/OS you are experiencing the problem with? ALL

If applicable, please provide a code snippet or link to a website
demonstrating the problem.

Chrome Error Console: "Uncaught TypeError: Cannot read property 'msie' of 
undefined"
Safari Error Console: "TypeError: 'undefined' is not an object (evaluating 
'b.browser.msie')" Line 8
Firefox Error Consol: TypeError: b.browser is undefined
Source File: http://thepoweroftouch.com/assets/js/jquery.simplemodal.min.js 
Line: 8

If applicable, please list the other code/libraries/plugins you are trying
to integrate with.
There are couple but after disabling them - issue persists, so they do not 
affect, except very likely the latest jQuery has changes in 'msie'?

Original issue reported on code.google.com by xander.a...@gmail.com on 16 Jan 2013 at 5:29

GoogleCodeExporter commented 9 years ago 
Yes it is confirmed - it is incompatibility with jQuery v1.9.0 - when reverted 
back to v1.8.3 - it works fine..

Original comment by xander.a...@gmail.com on 16 Jan 2013 at 7:27

GoogleCodeExporter commented 9 years ago 
And yes it is because jQuery.browser and jQuery.browser.version are now REMOVED 
from jQuery 1.9.0 - they mention there should be a plugin now for it..

Original comment by xander.a...@gmail.com on 16 Jan 2013 at 7:37

GoogleCodeExporter commented 9 years ago 
Thanks for reporting this. I've updated the code and this should be resolved in 
v1.4.4.

Original comment by emartin24 on 21 Jan 2013 at 2:57

GoogleCodeExporter commented 9 years ago 
AWESOME! Cheers!

Original comment by xander.a...@gmail.com on 21 Jan 2013 at 2:58

GoogleCodeExporter commented 9 years ago 
Thank you

Original comment by baybora....@gmail.com on 24 Jan 2013 at 7:46

GoogleCodeExporter commented 9 years ago 
Thank you!

Original comment by chris.st...@gmail.com on 26 Jan 2013 at 4:45