codepathreview
commented
7 years ago Hello lei.
Looks good, this exercise is intended in part to give you an introduction to the general rhythm of this course. The course is entirely project-based with an app being assigned each week and then due the following week. Each project builds on the last to help each engineer learn the practical elements of Web Security development and best practices as quickly as possible. We also do a code review for each submitted project once the program begins.
Your code doesn't contain next functionality:
- [*] PHP code sets reasonable default values for the form. -- no default values in the form, its empty
- [*] Page indicates any form errors which need to be fixed. -- no error messages are shown if we enter incorrect data.
Great to see you were able to complete some optional features to your app already. The optional tasks available on each project are often the most valuable learnings since they dive deeper into common real-world use cases. We encourage you to continue working on extensions to your tip calculator as a way to further explore development in PHP.
See if you can expand the functionality of the app or instead work to improve the user interface by experimenting with colors, spacing, styling, icons, etc. You can update your submission at any time here, and it will notify us to review again.
We'll be following up with you again shortly to outline the next steps in the admissions process.
Thanks for submitting your pre-work, but could you make some changes to your readme? Can you please review the section in the pre-work about the README for your project?
In particular, be sure to start from the README template that is linked there, check off your completed required and optional features ([x]), list any additional features, and include a recorded app walkthrough with LiceCap.
Please re-submit your project on your application dashboard, and it will notify us to review again.