search

lwa-project / lsl

LWA Software Library
GNU General Public License v2.0
8 stars 4 forks source link

Drop `numpy.matrix` in favor of `numpy.array` and `numpy.dot` #74

Closed jaycedowell closed 4 months ago

jaycedowell commented 4 months ago

This PR cleans up lsl.correlator.uvutils to remove calls to numpy.matrix. It also cleans up the various functions in this module to remove the indicies keyword.

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 94.50549% with 5 lines in your changes missing coverage. Please review.

Project coverage is 85.15%. Comparing base (a745ef8) to head (bcc530f). Report is 1 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/lwa-project/lsl/pull/74/graphs/tree.svg?width=650&height=150&src=pr&token=CNCKDKBX9R&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lwa-project)](https://app.codecov.io/gh/lwa-project/lsl/pull/74?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lwa-project) ```diff @@ Coverage Diff @@ ## main #74 +/- ## ========================================== + Coverage 85.08% 85.15% +0.06% ========================================== Files 83 83 Lines 23740 23743 +3 ========================================== + Hits 20199 20218 +19 + Misses 3541 3525 -16 ``` | [Files](https://app.codecov.io/gh/lwa-project/lsl/pull/74?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lwa-project) | Coverage Δ | | |---|---|---| | [lsl/sim/vis.py](https://app.codecov.io/gh/lwa-project/lsl/pull/74?src=pr&el=tree&filepath=lsl%2Fsim%2Fvis.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lwa-project#diff-bHNsL3NpbS92aXMucHk=) | `84.94% <100.00%> (+0.93%)` | :arrow_up: | | [lsl/correlator/uvutils.py](https://app.codecov.io/gh/lwa-project/lsl/pull/74?src=pr&el=tree&filepath=lsl%2Fcorrelator%2Fuvutils.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lwa-project#diff-bHNsL2NvcnJlbGF0b3IvdXZ1dGlscy5weQ==) | `92.24% <95.45%> (-2.80%)` | :arrow_down: | | [lsl/correlator/fx.py](https://app.codecov.io/gh/lwa-project/lsl/pull/74?src=pr&el=tree&filepath=lsl%2Fcorrelator%2Ffx.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lwa-project#diff-bHNsL2NvcnJlbGF0b3IvZngucHk=) | `95.20% <91.30%> (+7.10%)` | :arrow_up: | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/lwa-project/lsl/pull/74/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lwa-project)