search

lwa-project / orville_wideband_imager

The Orville Wideband Imager
https://leo.phys.unm.edu/~lwa/lwatv2.html
BSD 3-Clause "New" or "Revised" License
0 stars 2 forks source link

Make pip installable #22

Closed dentalfloss1 closed 4 months ago

dentalfloss1 commented 5 months ago

This would address issue #21 . I took some guesses on the information in setup.py @jaycedowell it would be helpful if you could edit that file to correct the description and version number.

jaycedowell commented 5 months ago

I did a little work on this to make it look more like https://github.com/lwa-project/pasi_image. It's better but I'm still not 100% happy with it. The things that are bothering me:

  1. namespace_packages is deprecated for setuptools. It needs to be migrated over to PEP 420
  2. Including bad_freq.txt in with the module is a mess. The current scheme works but it is ugly. Fixing this probably involves moving bad_freq.txt somewhere into the module's directory structure. Moving it would also require a change to orville_imager.py so that it defaults to using what's installed with in the module.
jaycedowell commented 5 months ago

That PR into the branch takes care of my two concerns. For (2) I decided to go with a sym link to the bad_freq.txt file that will install with the lsl_toolkits.

jaycedowell commented 4 months ago

@dentalfloss1 do the changes I've made to this still work for you?

dentalfloss1 commented 4 months ago

Looks good to me.

From: jaycedowell @.> Sent: Friday, June 21, 2024 8:56 AM To: lwa-project/orville_wideband_imager @.> Cc: Sarah Chastain @.>; Mention @.> Subject: Re: [lwa-project/orville_wideband_imager] Make pip installable (PR #22)

[EXTERNAL]

@dentalfloss1https://github.com/dentalfloss1 do the changes I've made to this still work for you?

— Reply to this email directly, view it on GitHubhttps://github.com/lwa-project/orville_wideband_imager/pull/22#issuecomment-2182912864, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AF35E63FAV3ETY4LHUFYT7TZIQ5JXAVCNFSM6AAAAABICDNGSCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBSHEYTEOBWGQ. You are receiving this because you were mentioned.Message ID: @.***>