search

lwaddicor / spring-startup-analysis

Simple module to analyse bean construction in Java Spring
Other
87 stars 5 forks source link

IDE-related files in the repository #1

Open volodymyrrudyi opened 7 years ago

volodymyrrudyi commented 7 years ago

Hello,

Thanks for the project, it looks rather interesting. I'm going ti add several more issues for cosmetic changes

The directory spring-startup-analysis/analyser contains IDE-related files (*.iml)

No IDE-specific files since end users and developers may use various Java IDEs for the development (IntelliJ, Eclipse, NetBeans)

lwaddicor commented 7 years ago

I was under the impression that it was ok to share the iml files. This seems to be the suggestion on the Jetbrains website and in the github gitignore repo

If it causes problems with other IDE's i'm open to removing it. Just might save intellij users some time

volodymyrrudyi commented 7 years ago

It's ok for IDE-related projects and non-mavenized projects, but in other cases, it's not really needed since instead of using Idea configs it's possible to import the pom.xm.

It's not causing any issues at all, just an additional file in the repo

gavlyukovskiy commented 7 years ago

Only one issue, when you're updating dependency in pom.xml you should update .iml as well, it's a bit anoying.

I agree with @volodymyrrudyi if the project hoster either by maven or gradle it's much easier to import project (just by fact, that you don't need to apply maven/gradle plugin then).

lwaddicor commented 7 years ago

Yeah, I'll take it out.