search

lwe / page_title_helper

Simple, internationalized and DRY page titles and headings for Rails.
MIT License
114 stars 9 forks source link

[CLEANUP] Fix the casing up the version-specific gemfiles #74

Closed oliverklee closed 7 years ago

lwe commented 7 years ago

(Sorry, deleted my previous comment)

Don't think it's reasonable to change the upcasing, because Gemfile itself is also upper-case, I think this is mainly a wrong default by rubocop and we should ignore casing rules for Gemfile* IMO.

Update: and please rebase, thx.

oliverklee commented 7 years ago

Done.

oliverklee commented 7 years ago

Strange … I'll investigate the failures.

lwe commented 7 years ago

Ahhh, this is why we included the explicit versions in the execution of Rubocop, otherwise it also examines .lock files. Can these be globally ignored maybe?

lwe commented 7 years ago

or maybe it's better to simply rename to rails-4-2.gemfile or smth, then it can easily be run on *.gemfile? (i suppose we even discussed this once, but I opposed it, sorry 😄)

oliverklee commented 7 years ago

I've just undone the changes to the RuboCop call. Hopefully, the build should now pass.

lwe commented 7 years ago

:tada: thanks