search

lwe / page_title_helper

Simple, internationalized and DRY page titles and headings for Rails.
MIT License
114 stars 9 forks source link

gemfiles/Gemfile.* are included in the gem #80

Closed oliverklee closed 4 years ago

oliverklee commented 7 years ago

It looks like the Gemfiles in gemflies/ get included in the gem because they match the pattern "Gemfile" in the gemspec in the "files" section.

Should we rename those files, e.g., from "Gemfile." to "gemfiles."?

lwe commented 7 years ago

Instead maybe change the inclusion rules of what gets included into the gem, personally I rather like that these have a similar name.

oliverklee commented 7 years ago

Well, the inclusion rule must include "Gemfile" so the "normal" Gemfile gets included. Maybe we can use a regular expression there?

oliverklee commented 4 years ago

This is not an issue anymore. Closing.