lweides / column-store

0 stars 0 forks source link

Master Branch protection rule #15

Closed Eliasrpx closed 1 year ago

Eliasrpx commented 1 year ago
Eliasrpx commented 1 year ago

Could you grant me Write/Admin permissions for this repository

lweides commented 1 year ago

Not sure that's possible 😂

Eliasrpx commented 1 year ago

should be no?: https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/managing-repository-settings/managing-teams-and-people-with-access-to-your-repository

lweides commented 1 year ago

Is not possible in repositories owned by a specific user. See https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-user-account-settings/permission-levels-for-a-personal-account-repository

Eliasrpx commented 1 year ago

alright. regarding the workflow: you should be able to just add the 'build' job to the status check of the master protection rule. adding a rule required status checks

lweides commented 1 year ago

See this PR: https://github.com/lweides/column-store/pull/16 - it has been approved, but because of failing status checks cannot be merged