search

lwfinger / rtl8188gu

This repo contains a Linux driver for the RTL8188GU
61 stars 20 forks source link

Fails to build on kernel 6.0.6 #12

Closed morngrar closed 2 years ago

morngrar commented 2 years ago

I have an x86_64 system running arch linux, and both branches of this repo fails to build today

Output from make on the master branch:

make ARCH=x86_64 CROSS_COMPILE= -C /lib/modules/6.0.6-arch1-1/build M=/home/sk/.local/build/rtl8188gu  modules
make[1]: Entering directory '/usr/lib/modules/6.0.6-arch1-1/build'
  CC [M]  /home/sk/.local/build/rtl8188gu/core/rtw_cmd.o
  CC [M]  /home/sk/.local/build/rtl8188gu/core/rtw_security.o
  CC [M]  /home/sk/.local/build/rtl8188gu/core/rtw_debug.o
  CC [M]  /home/sk/.local/build/rtl8188gu/core/rtw_io.o
  CC [M]  /home/sk/.local/build/rtl8188gu/core/rtw_ioctl_query.o
  CC [M]  /home/sk/.local/build/rtl8188gu/core/rtw_ioctl_set.o
  CC [M]  /home/sk/.local/build/rtl8188gu/core/rtw_ieee80211.o
  CC [M]  /home/sk/.local/build/rtl8188gu/core/rtw_mlme.o
  CC [M]  /home/sk/.local/build/rtl8188gu/core/rtw_mlme_ext.o
/home/sk/.local/build/rtl8188gu/core/rtw_mlme_ext.c: In function ‘rtw_txpwr_init_regd’:
/home/sk/.local/build/rtl8188gu/core/rtw_mlme_ext.c:764:20: warning: this statement may fall through [-Wimplicit-fallthrough=]
  764 |                 if (rfctl->regd_name)
      |                    ^
/home/sk/.local/build/rtl8188gu/core/rtw_mlme_ext.c:766:9: note: here
  766 |         default:
      |         ^~~~~~~
/home/sk/.local/build/rtl8188gu/core/rtw_mlme_ext.c: In function ‘mgt_dispatcher’:
/home/sk/.local/build/rtl8188gu/core/rtw_mlme_ext.c:1733:20: warning: this statement may fall through [-Wimplicit-fallthrough=]
 1733 |                 if (MLME_IS_AP(padapter))
      |                    ^
/home/sk/.local/build/rtl8188gu/core/rtw_mlme_ext.c:1738:9: note: here
 1738 |         case WIFI_ASSOCREQ:
      |         ^~~~
  CC [M]  /home/sk/.local/build/rtl8188gu/core/rtw_mi.o
  CC [M]  /home/sk/.local/build/rtl8188gu/core/rtw_wlan_util.o
  CC [M]  /home/sk/.local/build/rtl8188gu/core/rtw_vht.o
  CC [M]  /home/sk/.local/build/rtl8188gu/core/rtw_pwrctrl.o
  CC [M]  /home/sk/.local/build/rtl8188gu/core/rtw_rf.o
  CC [M]  /home/sk/.local/build/rtl8188gu/core/rtw_recv.o
  CC [M]  /home/sk/.local/build/rtl8188gu/core/rtw_sta_mgt.o
/home/sk/.local/build/rtl8188gu/core/rtw_sta_mgt.c: In function ‘rtw_mfree_stainfo’:
/home/sk/.local/build/rtl8188gu/core/rtw_sta_mgt.c:352:25: warning: the comparison will always evaluate as ‘true’ for the address of ‘lock’ will never be NULL [-Waddress]
  352 |         if (&psta->lock != NULL)
      |                         ^~
In file included from /home/sk/.local/build/rtl8188gu/include/drv_types.h:107,
                 from /home/sk/.local/build/rtl8188gu/core/rtw_sta_mgt.c:17:
/home/sk/.local/build/rtl8188gu/include/sta_info.h:229:17: note: ‘lock’ declared here
  229 |         _lock   lock;
      |                 ^~~~
  CC [M]  /home/sk/.local/build/rtl8188gu/core/rtw_ap.o
  CC [M]  /home/sk/.local/build/rtl8188gu/core/rtw_xmit.o
  CC [M]  /home/sk/.local/build/rtl8188gu/core/rtw_p2p.o
  CC [M]  /home/sk/.local/build/rtl8188gu/core/rtw_rson.o
  CC [M]  /home/sk/.local/build/rtl8188gu/core/rtw_tdls.o
  CC [M]  /home/sk/.local/build/rtl8188gu/core/rtw_br_ext.o
  CC [M]  /home/sk/.local/build/rtl8188gu/core/rtw_iol.o
  CC [M]  /home/sk/.local/build/rtl8188gu/core/rtw_sreset.o
  CC [M]  /home/sk/.local/build/rtl8188gu/core/rtw_btcoex_wifionly.o
  CC [M]  /home/sk/.local/build/rtl8188gu/core/rtw_btcoex.o
  CC [M]  /home/sk/.local/build/rtl8188gu/core/rtw_beamforming.o
  CC [M]  /home/sk/.local/build/rtl8188gu/core/rtw_odm.o
  CC [M]  /home/sk/.local/build/rtl8188gu/core/rtw_rm.o
  CC [M]  /home/sk/.local/build/rtl8188gu/core/rtw_rm_fsm.o
  CC [M]  /home/sk/.local/build/rtl8188gu/core/efuse/rtw_efuse.o
  CC [M]  /home/sk/.local/build/rtl8188gu/os_dep/osdep_service.o
  CC [M]  /home/sk/.local/build/rtl8188gu/os_dep/linux/os_intfs.o
  CC [M]  /home/sk/.local/build/rtl8188gu/os_dep/linux/usb_intf.o
  CC [M]  /home/sk/.local/build/rtl8188gu/os_dep/linux/usb_ops_linux.o
  CC [M]  /home/sk/.local/build/rtl8188gu/os_dep/linux/ioctl_linux.o
  CC [M]  /home/sk/.local/build/rtl8188gu/os_dep/linux/xmit_linux.o
  CC [M]  /home/sk/.local/build/rtl8188gu/os_dep/linux/mlme_linux.o
  CC [M]  /home/sk/.local/build/rtl8188gu/os_dep/linux/recv_linux.o
  CC [M]  /home/sk/.local/build/rtl8188gu/os_dep/linux/ioctl_cfg80211.o
/home/sk/.local/build/rtl8188gu/os_dep/linux/ioctl_cfg80211.c: In function ‘rtw_cfg80211_ch_switch_notify’:
/home/sk/.local/build/rtl8188gu/os_dep/linux/ioctl_cfg80211.c:405:9: error: too few arguments to function ‘cfg80211_ch_switch_notify’
  405 |         cfg80211_ch_switch_notify(adapter->pnetdev, &chdef);
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /home/sk/.local/build/rtl8188gu/include/osdep_service_linux.h:93,
                 from /home/sk/.local/build/rtl8188gu/include/osdep_service.h:47,
                 from /home/sk/.local/build/rtl8188gu/include/drv_types.h:27,
                 from /home/sk/.local/build/rtl8188gu/os_dep/linux/ioctl_cfg80211.c:17:
./include/net/cfg80211.h:8261:6: note: declared here
 8261 | void cfg80211_ch_switch_notify(struct net_device *dev,
      |      ^~~~~~~~~~~~~~~~~~~~~~~~~
/home/sk/.local/build/rtl8188gu/os_dep/linux/ioctl_cfg80211.c: In function ‘rtw_cfg80211_indicate_connect’:
/home/sk/.local/build/rtl8188gu/os_dep/linux/ioctl_cfg80211.c:983:26: error: ‘struct cfg80211_roam_info’ has no member named ‘bssid’
  983 |                 roam_info.bssid = cur_network->network.MacAddress;
      |                          ^
/home/sk/.local/build/rtl8188gu/os_dep/linux/ioctl_cfg80211.c: In function ‘cfg80211_rtw_scan’:
/home/sk/.local/build/rtl8188gu/os_dep/linux/ioctl_cfg80211.c:2691:33: warning: the comparison will always evaluate as ‘true’ for the address of ‘ssid’ will never be NULL [-Waddress]
 2691 |                 if (ssids->ssid != NULL
      |                                 ^~
./include/net/cfg80211.h:2357:12: note: ‘ssid’ declared here
 2357 |         u8 ssid[IEEE80211_MAX_SSID_LEN];
      |            ^~~~
/home/sk/.local/build/rtl8188gu/os_dep/linux/ioctl_cfg80211.c: At top level:
/home/sk/.local/build/rtl8188gu/os_dep/linux/ioctl_cfg80211.c:7475:20: error: initialization of ‘int (*)(struct wiphy *, struct net_device *, unsigned int)’ from incompatible pointer type ‘int (*)(struct wiphy *, struct net_device *)’ [-Werror=incompatible-pointer-types]
 7475 |         .stop_ap = cfg80211_rtw_stop_ap,
      |                    ^~~~~~~~~~~~~~~~~~~~
/home/sk/.local/build/rtl8188gu/os_dep/linux/ioctl_cfg80211.c:7475:20: note: (near initialization for ‘rtw_cfg80211_ops.stop_ap’)
/home/sk/.local/build/rtl8188gu/os_dep/linux/ioctl_cfg80211.c: In function ‘rtw_wdev_unregister’:
/home/sk/.local/build/rtl8188gu/os_dep/linux/ioctl_cfg80211.c:7718:17: error: ‘struct wireless_dev’ has no member named ‘current_bss’
 7718 |         if (wdev->current_bss) {
      |                 ^~
/home/sk/.local/build/rtl8188gu/os_dep/linux/ioctl_cfg80211.c: In function ‘cfg80211_rtw_change_iface’:
/home/sk/.local/build/rtl8188gu/os_dep/linux/ioctl_cfg80211.c:2151:24: warning: this statement may fall through [-Wimplicit-fallthrough=]
 2151 |                 is_p2p = _TRUE;
/home/sk/.local/build/rtl8188gu/os_dep/linux/ioctl_cfg80211.c:2153:9: note: here
 2153 |         case NL80211_IFTYPE_STATION:
      |         ^~~~
/home/sk/.local/build/rtl8188gu/os_dep/linux/ioctl_cfg80211.c:2175:24: warning: this statement may fall through [-Wimplicit-fallthrough=]
 2175 |                 is_p2p = _TRUE;
/home/sk/.local/build/rtl8188gu/os_dep/linux/ioctl_cfg80211.c:2177:9: note: here
 2177 |         case NL80211_IFTYPE_AP:
      |         ^~~~
cc1: some warnings being treated as errors
make[2]: *** [scripts/Makefile.build:249: /home/sk/.local/build/rtl8188gu/os_dep/linux/ioctl_cfg80211.o] Error 1
make[1]: *** [Makefile:1852: /home/sk/.local/build/rtl8188gu] Error 2
make[1]: Leaving directory '/usr/lib/modules/6.0.6-arch1-1/build'
make: *** [Makefile:1522: modules] Error 2
lwfinger commented 2 years ago

I fixed the build through kernel 6.1; however, I only see a single branch in this repo. I only fixed the errors. I do not have time now to address the warnings.