Warnings

[fliiiix]

Just FYI

rtl8723au/os_dep/os_intfs.c:954:2: warning: initialization from incompatible pointer type [enabled by default]
  .ndo_select_queue = rtw_select_queue,
  ^
rtl8723au/os_dep/os_intfs.c:954:2: warning: (near initialization for ‘rtw_netdev_ops.ndo_select_queue’) [enabled by default]

gcc version: 4.8.2 20131212 (Red Hat 4.8.2-7) (GCC) kernel: 3.13.5-202.fc20.x86_64 os: Fedora release 20 (Heisenbug)

[lwfinger]

Fixed and pushed. Let me know if the warning persists.

[fliiiix]

The warnings are away but now I got a error.

CC [M]  rtl8723au/os_dep/os_intfs.o
rtl8723au/os_dep/os_intfs.c:910:10: error: unknown type name ‘select_queue_fallback_t’
        , select_queue_fallback_t fallback
          ^
rtl8723au/os_dep/os_intfs.c:962:22: error: ‘rtw_select_queue’ undeclared here (not in a function)
  .ndo_select_queue = rtw_select_queue,
                      ^

[lwfinger]

Please tell me the definition of ndo_select_queue in file /lib/modules/uname -r/build/include/linux/netdev.h. Those special symbols are backticks, not single quotes.

[fliiiix]

I don't have a netdev.h on my fedora. I grep for it but it only appears in netdevice.h

grep -r "ndo_select_queue" .
./include/linux/netdevice.h: * u16 (*ndo_select_queue)(struct net_device *dev, struct sk_buff *skb,
./include/linux/netdevice.h:    u16         (*ndo_select_queue)(struct net_device *dev,

[lwfinger]

Yes, I realized I gave you the wrong name. I just pushed a fix.

[fliiiix]

:thumbsup: yeah the fix worked!

[emmeowzing]

I've tried running this on an Odroid XU4 (armv7l) and I get the following:

root@odroid-jessie:/home/uav/rtl8812au# make ARCH=arm
make ARCH=arm CROSS_COMPILE= -C /lib/modules/3.10.92+/build M=/home/uav/rtl8812au  modules
make[1]: Entering directory '/usr/src/linux-headers-3.10.92+'
  CC [M]  /home/uav/rtl8812au/core/rtw_cmd.o
  CC [M]  /home/uav/rtl8812au/core/rtw_security.o
  CC [M]  /home/uav/rtl8812au/core/rtw_debug.o
  CC [M]  /home/uav/rtl8812au/core/rtw_io.o
  CC [M]  /home/uav/rtl8812au/core/rtw_ioctl_query.o
  CC [M]  /home/uav/rtl8812au/core/rtw_ioctl_set.o
  CC [M]  /home/uav/rtl8812au/core/rtw_ieee80211.o
  CC [M]  /home/uav/rtl8812au/core/rtw_mlme.o
  CC [M]  /home/uav/rtl8812au/core/rtw_mlme_ext.o
  CC [M]  /home/uav/rtl8812au/core/rtw_wlan_util.o
  CC [M]  /home/uav/rtl8812au/core/rtw_vht.o
  CC [M]  /home/uav/rtl8812au/core/rtw_pwrctrl.o
  CC [M]  /home/uav/rtl8812au/core/rtw_rf.o
  CC [M]  /home/uav/rtl8812au/core/rtw_recv.o
  CC [M]  /home/uav/rtl8812au/core/rtw_sta_mgt.o
  CC [M]  /home/uav/rtl8812au/core/rtw_ap.o
  CC [M]  /home/uav/rtl8812au/core/rtw_xmit.o
  CC [M]  /home/uav/rtl8812au/core/rtw_p2p.o
  CC [M]  /home/uav/rtl8812au/core/rtw_tdls.o
  CC [M]  /home/uav/rtl8812au/core/rtw_br_ext.o
  CC [M]  /home/uav/rtl8812au/core/rtw_iol.o
  CC [M]  /home/uav/rtl8812au/core/rtw_sreset.o
  CC [M]  /home/uav/rtl8812au/core/efuse/rtw_efuse.o
  CC [M]  /home/uav/rtl8812au/os_dep/osdep_service.o
  CC [M]  /home/uav/rtl8812au/os_dep/linux/os_intfs.o
/home/uav/rtl8812au/os_dep/linux/os_intfs.c:1002:92: error: unknown type name ‘select_queue_fallback_t’
 static u16 rtw_select_queue(struct net_device *dev, struct sk_buff *skb, void *accel_priv, select_queue_fallback_t fallback)
                                                                                            ^
/home/uav/rtl8812au/os_dep/linux/os_intfs.c:1053:22: error: ‘rtw_select_queue’ undeclared here (not in a function)
  .ndo_select_queue = rtw_select_queue,
                      ^
scripts/Makefile.build:308: recipe for target '/home/uav/rtl8812au/os_dep/linux/os_intfs.o' failed
make[2]: *** [/home/uav/rtl8812au/os_dep/linux/os_intfs.o] Error 1
Makefile:1232: recipe for target '_module_/home/uav/rtl8812au' failed
make[1]: *** [_module_/home/uav/rtl8812au] Error 2
make[1]: Leaving directory '/usr/src/linux-headers-3.10.92+'
Makefile:1052: recipe for target 'modules' failed
make: *** [modules] Error 2

Any suggestions?

gcc (Debian 4.9.2-10) 4.9.2 kernel version 3.10.92+ OS odroid-jessie