lwfinger / rtl8723au

Repo for RTL8723AU code before Linux Kernel commit
126 stars 46 forks source link

Works but with warnings #40

Closed hoshsadiq closed 5 years ago

hoshsadiq commented 10 years ago

This works great! There's a couple of warnings during make:

  CC [M]  /home/hosh/git/rtl8723au/hal/Hal8723PwrSeq.o
  CC [M]  /home/hosh/git/rtl8723au/hal/rtl8723a_bt-coexist.o
  CC [M]  /home/hosh/git/rtl8723au/os_dep/osdep_service.o
  CC [M]  /home/hosh/git/rtl8723au/os_dep/os_intfs.o
/home/hosh/git/rtl8723au/os_dep/os_intfs.c:962:2: warning: initialization from incompatible pointer type [enabled by default]
  .ndo_select_queue = rtw_select_queue,
  ^
/home/hosh/git/rtl8723au/os_dep/os_intfs.c:962:2: warning: (near initialization for ‘rtw_netdev_ops.ndo_select_queue’) [enabled by default]
  CC [M]  /home/hosh/git/rtl8723au/os_dep/usb_intf.o
  CC [M]  /home/hosh/git/rtl8723au/os_dep/usb_ops_linux.o

Despite these warnings, it compiles fine and installs and works correct.

Also, a simple install script that would be handy to be part of the repository:

#!/bin/bash
make clean
make
sudo make install

sudo modprobe 8723au
lwfinger commented 10 years ago

What kernel are you using?

The driver is in the 3.15 kernel, thus I will not be maintaining this repo much longer.

hoshsadiq commented 10 years ago

I'm on 3.13.0-27-generic (latest Ubuntu 14.04 I think). But it's fine. I just thought I'd let you know :)

lwfinger commented 10 years ago

The code is correct, but you may have a stale include/linux/version.h in your kernel headers tree. Some time ago, they changed to using include/uapi/linux/version.h as a replacement, but the kernel generation never clears the old one. I got some very strange results until I discovered that problem.