search

lwfinger / rtl8723bu

Driver for RTL8723BU
283 stars 143 forks source link

Indicate disconnection events when disconnecting #185

Closed dougg3 closed 2 years ago

dougg3 commented 2 years ago

I did not author this commit, but I found it in another repository (https://github.com/endlessm/linux/commit/eb1bdcedc448a03ffe899b54eb455d253acc6b2b). This fixes an issue that prevents you from changing between access points.

In the current version of this driver, I am unable to change which AP I connect to. Once I've connected to an AP, I'm stuck with that AP. If I try to connect to a different AP, everything gets messed up and it never successfully connects ever again, until I remove the kernel module and reinsert it (or reboot). It just prints this over and over again while trying to connect:

RTL871X: nolinked power save enter
RTL871X: RTW_ADAPTIVITY_EN_
AUTO, chplan:0x20, Regulation:0,0
RTL871X: RTW_ADAPTIVITY_MODE_
NORMAL
RTL871X: nolinked power save leave

As you can see in the commit message by the original author, it seems as though there's some weird unnecessary event suppression going on in this driver that Realtek removed in newer drivers for other hardware. This commit definitely fixes the issue for me. After applying this patch, I am able to connect to any number of APs with no trouble.

lwfinger commented 2 years ago

The patch appears fine. I did not devote much time to seeing how it works, but as you say is does, it is merged.

dougg3 commented 2 years ago

Wow, thanks for the super fast merge! For what it’s worth, I’ve been testing this change for the past 2 years on devices all over the United States and haven’t run into any problems with it. Just finally thought today about submitting it upstream to here.