lwfinger / rtl8723bu

Driver for RTL8723BU
284 stars 144 forks source link

Changes for DKMS build #24

Closed dmig closed 6 years ago

dmig commented 8 years ago

I dropped original driver archive, added dkms.conf and made small fix to Makefile. Without this fix to Makefile dkms fails to build 8732bu.ko.

This configuration runs well for me with kernels being updating automatically.

lwfinger commented 8 years ago

Your change to Makefile are OK and I assume that the DKMS changes are OK, but why did you delete the "original" archive when that code is in fact a new version?

The main driver is "v4.3.6.11_12942.20141204_BTCOEX20140507-4E40". The code that you deleted is "v4.3.16_14189.20150519_BTCOEX20150119-5844" and is about 6 months newer. I added it to the repo so that I could have a user test it to see if it fixed any problems with the main code. I am not happy that you are deleting it, and I will not do so. If it interferes with a DKMS build, then fix dkms.conf!

dmig commented 8 years ago

There were no real need of deleting it, I just wanted to remove file useless for building.

I think, better way is not to keep it in repo as archive, but make a branch or another repo with its contents

lwfinger commented 8 years ago

Possible, but then both versions are not available at the same time for comparison while in the master branch. If you are so short of disk space that removing it is important, then you had best fork and remove my repo. Of course, that would complicate your following my updates.

dmig commented 8 years ago

You say, code in archive was "v4.3.16_14189.20150519_BTCOEX20150119-5844", but what I found is: include/rtw_version.h:1:#define DRIVERVERSION "v4.3.6.11_12942.20141204_BTCOEX20140507-4E40"

And your commit message for that archive said: "Add original tar file to repo".

lwfinger commented 8 years ago

finger@linux:~/rtl8723bu> git checkout v4.3.16 Switched to branch 'v4.3.16' finger@linux:~/rtl8723bu> grep -r DRIVERVER include/* include/rtw_version.h:#define DRIVERVERSION "v4.3.16_14189.20150519_BTCOEX20150119-5844"

finger@linux:~/rtl8723bu> git checkout master Switched to branch 'master' Your branch is up-to-date with 'origin/master'. finger@linux:~/rtl8723bu> grep -r DRIVERVER include/* include/rtw_version.h:#define DRIVERVERSION "v4.3.6.11_12942.20141204_BTCOEX20140507-4E40"

Both are there. It depends on which branch you check out.

howardqiao commented 8 years ago

@lwfinger Thanks for your great work,the driver works perfectly with Comfast wu725b usb dongle(http://www.comfast.com.cn/product/item-260.html) ,but another module cannot find any ssid(http://www.aliexpress.com/store/product/RTL8723BU-COMBO-module-14-pin-RL-UM02WBS-8723BU-V1-2-13-4-12-2mm-WIFI-GSPI/704833_32471521628.html) ,the module test on win10,works ok.

pi@raspberrypi:~/test/rtl8723bu $ iwlist wlan0 scanning wlan0 No scan results

I want to test 4.3.16 branch,but it seems to be have master branch only.

`pi@raspberrypi:~/test/rtl8723bu $ git checkout v4.3.16 error: pathspec 'v4.3.16' did not match any file(s) known to git. pi@raspberrypi:~/test/rtl8723bu $ git branch

could you give me some advices?

` [ 10.370851] RTL871X: RTW_ADAPTIVITY_EN_AUTO, chplan:0x20, Regulation:0,0 [ 10.370876] RTL871X: RTW_ADAPTIVITY_MODE_NORMAL [ 11.047502] IPv6: ADDRCONF(NETDEV_UP): wlan0: link is not ready [ 11.638396] Adding 102396k swap on /var/swap. Priority:-1 extents:3 across:1773568k SSFS [ 11.764376] cfg80211: Regulatory domain changed to country: GB [ 11.764414] cfg80211: DFS Master region: ETSI [ 11.764424] cfg80211: (start_freq - end_freq @ bandwidth), (max_antenna_gain, max_eirp), (dfs_cac_time) [ 11.764439] cfg80211: (2402000 KHz - 2482000 KHz @ 40000 KHz), (N/A, 2000 mBm), (N/A) [ 11.764452] cfg80211: (5170000 KHz - 5250000 KHz @ 80000 KHz, 160000 KHz AUTO), (N/A, 2000 mBm), (N/A) [ 11.764466] cfg80211: (5250000 KHz - 5330000 KHz @ 80000 KHz, 160000 KHz AUTO), (N/A, 2000 mBm), (0 s) [ 11.764480] cfg80211: (5490000 KHz - 5710000 KHz @ 160000 KHz), (N/A, 2700 mBm), (0 s) [ 11.764493] cfg80211: (57000000 KHz - 66000000 KHz @ 2160000 KHz), (N/A, 4000 mBm), (N/A) [ 12.004471] usb 1-1-port3: disabled by hub (EMI?), re-enabling... [ 12.005119] usb 1-1.3: USB disconnect, device number 4 [ 12.005137] usb 1-1.3.1: USB disconnect, device number 6 [ 12.006966] Bluetooth: BNEP (Ethernet Emulation) ver 1.3 [ 12.006992] Bluetooth: BNEP filters: protocol multicast [ 12.007024] Bluetooth: BNEP socket layer initialized [ 12.032653] RTL871X: rtw_cmd_thread: DriverStopped(0) SurpriseRemoved(1) break at line 480

`

lwfinger commented 8 years ago

What does 'git branch -a' show?

howardqiao commented 8 years ago

` pi@raspberrypi:~/rtl8723bu $ git branch -a

pi@raspberrypi:~/rtl8723bu $

`

lwfinger commented 8 years ago

You did not do a full 'git clone'. If you had, you would get

finger@linux-1t8h:~/rtl8723bu> git branch -a

howardqiao commented 8 years ago

Sorry,I am a novice at github, so right? http://imgur.com/a/Av2ME http://imgur.com/f029H0w http://imgur.com/WhZpScs

lwfinger commented 8 years ago

After you clone the repo, you need to cd into that direstory before other git commands will work.

howardqiao commented 8 years ago

Very sorry,could you try to clone and have a test,still can not find another branch.like this pic. http://i.imgur.com/ozXIDC4.png