lwfinger / rtl8723ds

Linux driver for RTL8723DS.
GNU General Public License v2.0
50 stars 45 forks source link

rtl8723ds: fix rtnl_lock handling #31

Closed johnkeeping closed 1 year ago

johnkeeping commented 1 year ago

The important commit here fixes the locking in rtw_os_ndev_register() and rtw_os_ndev_unregister(); the other commit is just removing an unnecessary check since we're guaranteed to already hold rtnl_lock.

For registration, I have seen cases where register_netdevice() is being called without holding rtnl_lock because it is being held by another task and this breaks all the locking requirements.

lwfinger commented 1 year ago

Merged. Thanks.

johnkeeping commented 1 year ago

I'm not seeing this on master - did something go wrong with the merge?

lwfinger commented 1 year ago

I have no idea what went wrong. It is merged now.