lwfinger / rtl8723du

89 stars 43 forks source link

make fails compiling rtw_p2p.c #19

Closed pghpete closed 2 years ago

pghpete commented 2 years ago

This worked previously but doesn't after the latest OS update... make is failing while trying to comple rtw_p2p.c with the following error...

OS: Fedora 35 Kernel: 5.17.4-200

8723du-driver/rtl8723du/core/rtw_p2p.c: In function ‘process_assoc_req_p2p_ie’:
8723du-driver/rtl8723du/core/rtw_p2p.c:2306:46: error: passing argument 1 of ‘dev_addr_set’ from incompatible pointer type [-Werror=incompatible-pointer-types]
 2306 |                                 dev_addr_set(psta, pattr_content);
      |                                              ^~~~
      |                                              |
      |                                              struct sta_info *
In file included from 8723du-driver/rtl8723du/include/osdep_service_linux.h:19,
                 from 8723du-driver/rtl8723du/include/osdep_service.h:31,
                 from 8723du-driver/rtl8723du/include/drv_types.h:16,
                 from 8723du-driver/rtl8723du/core/rtw_p2p.c:6:
./include/linux/netdevice.h:4353:52: note: expected ‘struct net_device *’ but argument is of type ‘struct sta_info *’
 4353 | static inline void dev_addr_set(struct net_device *dev, const u8 *addr)
      |                                 ~~~~~~~~~~~~~~~~~~~^~~
cc1: some warnings being treated as errors
make[2]: *** [scripts/Makefile.build:288: 8723du-driver/rtl8723du/core/rtw_p2p.o] Error 1
make[1]: *** [Makefile:1841: 8723du-driver/rtl8723du] Error 2
make[1]: Leaving directory '/usr/src/kernels/5.17.4-200.fc35.x86_64'
make: *** [Makefile:199: modules] Error 2
lwfinger commented 2 years ago

I just pushed the fix. I got too eager to replace the copy operations to dev_addr. This one did not need replacing. Do a 'git pull' and it should be OK.

pghpete commented 2 years ago

Thank you! I'll give it a shot later this evening.

pghpete commented 2 years ago

Works perfectly. Thank you!