rtw_cfg80211_ch_switch_notify triggers a warning

[jhofstee]

The current version, 47f5f90b797d3f8848285a369dcfa6ff5819607c, triggers a WARN_ON in linux 5.10.186. Initializing struct cfg80211_chan_def chdef = {}; doesn't help. This triggers the warning, https://github.com/victronenergy/linux/blob/jeroen/venus-5.10.186/net/wireless/nl80211.c#L17148. That is a temporary branch, but is based on the latest stable of 5.10.

The WARN_ON is not present on linux v6.4 though. It is also not present in cfcb42ad6f9bc9bc987ef2f2841f15ce5fb4bbdb.

Since I don't know anything about these drivers any suggestion what might be causing it is welcome.

[    9.511375] ------------[ cut here ]------------
[    9.516378] WARNING: CPU: 0 PID: 595 at net/wireless/nl80211.c:17148 cfg80211_ch_switch_notify+0xb0/0xb4 [cfg80211]
[    9.527040] Modules linked in: cmac algif_hash algif_skcipher af_alg ip6table_filter ip6_tables xt_conntrack nf_conntrack nf_defrag_ipv6 libcrc32c nf_defrag_ipv4 iptable_filter ip_tables x_tables dwmac_sun8i stmmac_platform governor_simpleondemand 8723du(O) stmmac btusb btrtl btintel btbcm sun8i_drm_hdmi pcs_xpcs mcp251xfd phylink dw_hdmi pwm_sun4i ftdi_sio edt_ft5x06 mdio_mux of_mdio can_dev usbserial fixed_phy lima victron_gxdisp_bl bluetooth libphy cfg80211 ecdh_generic ti_tla2024 ecc industrialio lm75 gpu_sched rfkill sun4i_drm sun4i_frontend sun4i_tcon sun8i_mixer sun8i_tcon_top drm_kms_helper cfbfillrect syscopyarea cfbimgblt sysfillrect sysimgblt fb_sys_fops cfbcopyarea fb font drm drm_panel_orientation_quirks
[    9.591041] CPU: 0 PID: 595 Comm: RTW_CMD_THREAD Tainted: G           O      5.10.186-venus-11 #1
[    9.599943] Hardware name: Allwinner sun8i Family
[    9.604751] [<c010d1e4>] (unwind_backtrace) from [<c010a2e4>] (show_stack+0x10/0x14)
[    9.612578] [<c010a2e4>] (show_stack) from [<c0662a2c>] (dump_stack+0x98/0xac)
[    9.619822] [<c0662a2c>] (dump_stack) from [<c0660980>] (__warn+0xa0/0xb8)
[    9.626707] [<c0660980>] (__warn) from [<c06609fc>] (warn_slowpath_fmt+0x64/0xc0)
[    9.634392] [<c06609fc>] (warn_slowpath_fmt) from [<bf275a9c>] (cfg80211_ch_switch_notify+0xb0/0xb4 [cfg80211])
[    9.645461] [<bf275a9c>] (cfg80211_ch_switch_notify [cfg80211]) from [<bf40ca80>] (rtw_cfg80211_ch_switch_notify+0x94/0x9c [8723du])
[    9.658646] [<bf40ca80>] (rtw_cfg80211_ch_switch_notify [8723du]) from [<bf3b1234>] (rtw_chk_start_clnt_join+0x3cc/0x5fc [8723du])
[    9.671561] [<bf3b1234>] (rtw_chk_start_clnt_join [8723du]) from [<bf3b1698>] (join_cmd_hdl+0x234/0x328 [8723du])
[    9.683155] [<bf3b1698>] (join_cmd_hdl [8723du]) from [<bf3792b0>] (rtw_cmd_thread+0x41c/0x768 [8723du])
[    9.693569] [<bf3792b0>] (rtw_cmd_thread [8723du]) from [<c01438c0>] (kthread+0x108/0x134)
[    9.701926] [<c01438c0>] (kthread) from [<c0100148>] (ret_from_fork+0x14/0x2c)
[    9.709195] Exception stack(0xc19e3fb0 to 0xc19e3ff8)
[    9.714294] 3fa0:                                     00000000 00000000 00000000 00000000
[    9.722484] 3fc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
[    9.730692] 3fe0: 00000000 00000000 00000000 00000000 00000013 00000000
[    9.737717] ---[ end trace 3edc9b246c5bdd5b ]---

[lwfinger]

I am no longer supporting this repo. Try https://github.com/lwfinger/rtw88.git. That repo does handle rtw8723 and is supported.

[jhofstee]

Ok, thanks!