search

lwfinger / rtw88

A backport of the Realtek Wifi 5 drivers from the wireless-next repo.
649 stars 183 forks source link

Fixes small changes in Makefile(pr #211) #214

Closed gtisan closed 4 months ago

gtisan commented 4 months ago

I didn't know how to change the commit history of pr #211 therefore I created a new pull request to fix the problem with SDIO.

You can delete old pr #211 or I can do it after review.

dubhater commented 4 months ago

It still doesn't work. :) I have CONFIG_PCI=y and CONFIG_USB=y, but CONFIG_MMC=m.

a5a5aa555oo commented 4 months ago

On ArchLinux/Debian ====> CONFIG_MMC=m On Ubuntu/LinuxMint ====> CONFIG_MMC=y

so ifneq ($(CONFIG_MMC), ) should be better.

gtisan commented 4 months ago

Thanks, I did it.

In this repo the firmware for 8822cu(rtw8822c_fw.bin) is older than in linux-firmware. Is it fine or should we upgrade to the latest firmware ?

dubhater commented 4 months ago

We should upgrade the firmware.

a5a5aa555oo commented 4 months ago

I compared the firmware files here with the ones in linux-firmware, and the result is as below: rtl8822cu_fw.bin: firmware for bt, older than the one in linux-firmware (0xFFB8_ABD3 vs AED6_6DCB) rtw8723d_fw.bin: identical rtw8812a_fw.bin: only exist in this repo rtw8821a_fw.bin: identical rtw8821c_fw.bin: older than the one in linux-firmware (v24.8 vs v24.11) rtw8822b_fw.bin: identical rtw8822c_fw.bin: older than the one in linux-firmware (v9.9.13 vs v9.9.15) rtw8822c_wow_fw.bin: identical

I can upgrade them and put all the firmware files in a folder called "firmware" if you permit.

dubhater commented 4 months ago

@a5a5aa555oo Sounds good to me. I think we can delete the Bluetooth firmware because this repository doesn't provide Bluetooth drivers.

a5a5aa555oo commented 4 months ago

@dubhater I think so,too. I will delete rtl8822cu_fw.bin and add/upgrade all the firmware needed for rtw88, thank you!~

dubhater commented 4 months ago

Merged, thank you!

dubhater commented 4 months ago

@gtisan Does this break the uninstall target? It tries to unload the SDIO modules, which maybe weren't compiled. If the module doesn't exist at all, modprobe -r fails and make aborts.

https://github.com/morrownr/8812au-20210820/issues/27#issuecomment-2246550487