search

lwfinger / rtw88

A backport of the Realtek Wifi 5 drivers from the wireless-next repo.
649 stars 183 forks source link

Fix module unloading when removing the driver #230

Closed a5a5aa555oo closed 3 months ago

a5a5aa555oo commented 3 months ago

On Debian/Ubuntu and some other distros, the recipes in Makefile are executed by dash shell which doesn't support brace expansion, and this causes the modules won't be unloaded when removing the driver, so in this commit we use another way to unload them.

Tested on Arch Linux and Debian 11.10.

morrownr commented 3 months ago

Thanks. I have run into little inconsistencies like this many times.

By the way, Dubhater was looking for a lost firmware file that seemed to disappear with the firmware reorganization you did.

They are discussing it here at the end of the thread:

https://github.com/morrownr/8821au-20210708/issues/133#issuecomment-2282313202

a5a5aa555oo commented 3 months ago

@morrownr

I believe I didn't delete that file, I'll see what happened.

https://github.com/lwfinger/rtw88/commit/c66b562736963886a2caa5bbfe2df848ac6d35c5

morrownr commented 3 months ago

@a5a5aa555oo

I believe I didn't delete that file, I'll see what happened.

You probably did not but it was strange when it ended up missing. I don't think we will need but we did find how to get if need be.

Hey, are you interested in having some fun? I would like to stand up a repo very similar to this one but with mt76 instead of rtw88. I have already made a private repo and filled it with mt76 from wireless-next. We could make some decisions and start bring certain files from here that we could use to start. There is some work that needs to be done and we need something like this for mt76. Wanna help?

a5a5aa555oo commented 3 months ago

You probably did not but it was strange when it ended up missing. I don't think we will need but we did find how to get if need be.

I checked the commit history in recent one year, no one added/deleted rtw8811au_fw.bin, so I think this file is never is the master branch.

Hey, are you interested in having some fun? I would like to stand up a repo very similar to this one but with mt76 instead of > > rtw88. I have already made a private repo and filled it with mt76 from wireless-next. We could make some decisions and start bring certain files from here that we could use to start. There is some work that needs to be done and we need something like this for mt76. Wanna help?

Sure, but it is a work bigger than rtw88, I will help as possible as I could.

morrownr commented 3 months ago

but it is a work bigger than rtw88,

Actually less as Mediatek does not make new chips every 2 months for the same class of wifi. Mediate does have a lot of drivers for things not associated with usb. In fact, a lot of Mediatek drivers are Linux only as the hardware is for use cases that are Linux only such as phones, tv's and more. The only 3 drivers we would be looking at for now are:

mt7610u mt7612u mt7921au and the mt7925 when an adapter is actually on the market

I can add you to the private repo now if you want. I intend to try to get a couple of more folks also. We can talk and plan. Probably won't take long.

morrownr commented 3 months ago

Oh, that mt7925 is WiFi 7. The driver has been in the kernel since 6.7. I have a M.2 card with the chip and use it with Ubuntu 24.04. It is Plug and Play so to speak. Mediatek's WiFi Linux support is so much better than Realtek's. Do you need an adapter?