lwfinger / rtw89

Driver for Realtek 8852AE, an 802.11ax device
GNU General Public License v2.0
1.28k stars 161 forks source link

Typo in core.c #279

Open Sauerlandlinux opened 1 year ago

Sauerlandlinux commented 1 year ago

Building in openSUSE as rpm, typo in line 3909

[ 62s] /home/abuild/rpmbuild/BUILD/rtw89-5.17~62.gbb980e8/obj/default/core.c: In function 'rtw89_init_he_cap': [ 62s] /home/abuild/rpmbuild/BUILD/rtw89-5.17~62.gbb980e8/obj/default/core.c:3909:7: error: 'IEEE80211_HE_PHY_CAP9_NOMIMAL_PKT_PADDING_16US' undeclared (first use in this function); did you mean 'IEEE80211_HE_PHY_CAP9_NOMINAL_PKT_PADDING_16US'? [ 62s] IEEE80211_HE_PHY_CAP9_NOMIMAL_PKT_PADDING_16US; [ 62s] ^~~~~~~~~~ [ 62s] IEEE80211_HE_PHY_CAP9_NOMINAL_PKT_PADDING_16US [ 62s] /home/abuild/rpmbuild/BUILD/rtw89-5.17~62.gbb980e8/obj/default/core.c:3909:7: note: each undeclared identifier is reported only once for each function it appears in

Sauerlandlinux commented 1 year ago

Here is a patch:

diff -U 3 -H -d -r -N -- a/core.c b/core.c
--- a/core.c    2023-11-05 16:42:38.331156134 +0100
+++ b/core.c    2023-11-05 17:22:26.055370953 +0100
@@ -3906,7 +3906,7 @@
                  IEEE80211_HE_PHY_CAP9_RX_FULL_BW_SU_USING_MU_WITH_COMP_SIGB |
                  IEEE80211_HE_PHY_CAP9_RX_FULL_BW_SU_USING_MU_WITH_NON_COMP_SIGB |
 #if LINUX_VERSION_CODE < KERNEL_VERSION(5, 17, 0)
-                 IEEE80211_HE_PHY_CAP9_NOMIMAL_PKT_PADDING_16US;
+                 IEEE80211_HE_PHY_CAP9_NOMINAL_PKT_PADDING_16US;
 #else
                  u8_encode_bits(IEEE80211_HE_PHY_CAP9_NOMINAL_PKT_PADDING_16US,
                         IEEE80211_HE_PHY_CAP9_NOMINAL_PKT_PADDING_MASK);
diff -U 3 -H -d -r -N -- a/fw.c b/fw.c
--- a/fw.c  2023-11-03 17:09:04.222008548 +0100
+++ b/fw.c  2023-11-05 17:21:53.819638113 +0100
@@ -1865,7 +1865,7 @@
        u8 pad;

 #if LINUX_VERSION_CODE < KERNEL_VERSION(5, 17, 0)
-       pad = FIELD_GET(IEEE80211_HE_PHY_CAP9_NOMIMAL_PKT_PADDING_MASK,
+       pad = FIELD_GET(IEEE80211_HE_PHY_CAP9_NOMINAL_PKT_PADDING_MASK,
 #else
        pad = FIELD_GET(IEEE80211_HE_PHY_CAP9_NOMINAL_PKT_PADDING_MASK,
 #endif
Sauerlandlinux commented 1 year ago

It was an error with the backported Kernel from openSUSE, all builds fine.

So close it.