search

lwilletts / mpvc

An mpc-like control interface for mpv.
MIT License
139 stars 18 forks source link

Allow options to be passed to mpv when initializing playlists. #23

Closed woorst closed 8 years ago

woorst commented 8 years ago

All options after -- are passed to mpv when it is first opened.

heckendorfc commented 8 years ago

I like this (haven't tested though) but it looks like the --no-audio-display default is gone now. Wouldn't it be better to leave that default as-is and have the user use "-- --audio-display" to override it?

woorst commented 8 years ago

It's still there. See line 8 of the file. Also, you'd need to use --audio-display=attachment to override.

heckendorfc commented 8 years ago

Ah, you're correct on both points. I'll play with it in a few hours and merge unless @wildefyr beats me to it or disagrees.

woorst commented 8 years ago

Take note: there is no check to see if passed options are valid for mpv.

lwilletts commented 8 years ago

Revert 9f8ae5eec8e2e92bbc37ffd4f24f45c319663e94 : I don't see the point of this modification at all. Otherwise I'd be happy to merge once the conflicts are sorted out.

heckendorfc commented 8 years ago

9f8ae5e is actually the same concept as the already committed 8f1c8b1, but it's already in the source and doesn't belong in this PR anyway.