search

lwilletts / mpvc

An mpc-like control interface for mpv.
MIT License
139 stars 18 forks source link

Script not POSIX on OpenBSD #37

Closed mitchweaver closed 6 years ago

mitchweaver commented 6 years ago

Not currently working with the #!/bin/sh shebang that comes default on OpenBSD, (which has /bin/sh linked to ksh)

proof: Image

Changing the shebang to /bin/bash solves all problems -- works flawlessly.

Request: make POSIX to remove bash dependency

heckendorfc commented 6 years ago

Try the latest commit and let me know how it works for you.

mitchweaver commented 6 years ago

Works great, thanks! :+1:

heckendorfc commented 6 years ago

Cool, thanks for reporting.

@lwilletts was there a specific platform you found that type didn't work on? hash can't be used to check for a program's existence on ksh since it doesn't return anything.

lwilletts commented 6 years ago

Was not aware of the difference on ksh. Recommend we go back to using type for everything.