Factoring and enqueuing https:// URLs (enhancement)

lwilletts / mpvc

An mpc-like control interface for mpv.

MIT License

139 stars 18 forks source link

Factoring and enqueuing https:// URLs (enhancement) #46

Closed gmt4 closed 1 year ago

gmt4 commented 2 years ago

Hi there,

Forked the code at https://github.com/gmt4/mpvc/commits/master, For now it's been just a few minor things to get going, such as:

Factoring a bit the code
Minor changes for enqueuing https:// URL with: mpvc -a https://...

Just to let you know in case there's something you find useful.

lwilletts commented 2 years ago

Hi @gmt4

Happy for the vast majority of changes to be merged minus the README and Makefile updates. If you could revert those and open a pull request I'll get the new commits merged. I've been meaning to update the README for some time...

I haven't had much time to work on mpvc recently, so I'm glad it's still getting some use.

gmt4 commented 2 years ago

Pull Request opened at https://github.com/lwilletts/mpvc/pull/48

gmt4 commented 2 years ago

I synced mpvc with upstream and did a commit of the changes as a single commit:

https://github.com/gmt4/mpvc/commit/ec5e1ab1e596f2047a18b69f7cb71da488273cfa

gmt4 commented 1 year ago

There's been performance & new features improvements in the https://github.com/gmt4/mpvc fork. Is there interest in merging these changes back?

lwilletts commented 1 year ago

Merged.