lwindolf / liferea

Liferea (Linux Feed Reader), a news reader for GTK/GNOME
https://lzone.de/liferea
GNU General Public License v2.0
804 stars 131 forks source link

Revision signature in About #1319

Open bbhtt opened 8 months ago

bbhtt commented 8 months ago

Not very familiar with autoconf/automake but the idea should work. I've tried to keep it very simple.

Note.

Fixes https://github.com/lwindolf/liferea/issues/1258

Images From the current HEAD git commit that does not belong to a tag: ![5986e03ddb](https://github.com/lwindolf/liferea/assets/62639087/867d13bd-3aaa-46c3-95e1-b94226877d0d) From a checked out tag https://github.com/bbhtt/liferea/releases/tag/v1.110.819: ![cfd58e2868](https://github.com/lwindolf/liferea/assets/62639087/db224bb4-c690-46a4-943c-77361d1b4a5c)
bbhtt commented 8 months ago

The issue is intlool-update doesn't support m4_esyscmd_s but does m4_esyscmd. I wanted to use the latter to avoid newlines. I guess I'll add stripping instead.

lwindolf commented 5 months ago

Sorry for taking so long to review.

I'm very unsure whether the solution would work well, as I cannot predict the build enviroment of package maintainers. They more or less rely on configure.ac to statically provide a version. And we cannot predict wether they'll build from a git checkout or using a fresh source directory (make dist).

bbhtt commented 5 months ago

In case it is not from git, it reads the first line of the .version file using head.

Instead of the static version in configure.ac it will be now in .version. The version file will be included in tarballs when make dist is run.

Here is a tarball produced from source using make dist https://github.com/bbhtt/liferea/releases/download/v1.110.819/liferea-v1.15.4.tar.gz

I don't think that will be an issue?