search

lwindolf / liferea

Liferea (Linux Feed Reader), a news reader for GTK/GNOME
https://lzone.de/liferea
GNU General Public License v2.0
804 stars 131 forks source link

New Subscription shown on start up #1359

Open AndyM48 opened 1 month ago

AndyM48 commented 1 month ago

Whenever I start liferea I have a feed "New Subscription" shown which have to delete.

I have checked and it is not shown in feedlist.opml

lwindolf commented 1 month ago

Which start command do you use to start Liferea? Because we have a helper script "liferea-add-feed" which will launch Liferea with a new subscription. It sounds like you maybe using it.

AndyM48 commented 1 month ago

I added your .desktop file to my autostart folder so the start command is Exec=liferea %U

lwindolf commented 1 month ago

Sounds harmless

AndyM48 commented 1 month ago

It is a nuisance having to delete it every time liferea starts!

AndyM48 commented 1 month ago

and each time it starts it adds another "New Subscription" if it is not deleted.

Starting without the %U or "%U" removes the problem.

nekohayo commented 11 hours ago

It's a bit unclear whether you created your own custom launcher to begin with, or if you are using the standard one provided by the package and desktop environment.

Overall this ticket here is not a bug report, I would recommend closing it now.

AndyM48 commented 6 hours ago

No, as I said, I used your .desktop file to launch liferea on startup. I will check to see if there is still a problem.

Yes, same problem, liferea %U adds a New Subscription every time.

Artix (Arch) Linux 6.9.6 Openbox 3.6.1-10 Liferea 1.14.6

AndyM48 commented 5 hours ago

It seems that the standard launcher can accept a URL and add it if present. If no URL is present then "New Subscription" is used instead. This is without a -a flag.

If this is not the intention then what is the reason for adding the %U to the launcher exec command?

lwindolf commented 1 hour ago

@AndyM48 The .desktop file defining the %U is to serve to use cases

Both use case call Liferea with the desktop file and need to be supported. When I start with

liferea ""

the current code creates a new subscription. I think this might be what is happening in your case. Why this only happens for you I cannot tell.

I'll add a check for empty strings to the code to solve this.

AndyM48 commented 1 hour ago

Understood.

Why this only happens for you I cannot tell. Nor me

Please note in my previous comment, if %U is an existing subscription, liferea will ADD the %U as a new subscription, so checking for an empty string would only be a partial answer, you would also have to check for a duplicate of an existing subscription, and if true, open with the focus on the existing subscription instead of re-adding it.